[webkit-reviews] review granted: [Bug 28095] [WINCE] W3C Geolocation backend : [Attachment 34364] W3C Geolocation for WINCE

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Aug 8 07:41:11 PDT 2009


Eric Seidel <eric at webkit.org> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 28095: [WINCE] W3C Geolocation backend
https://bugs.webkit.org/show_bug.cgi?id=28095

Attachment 34364: W3C Geolocation for WINCE
https://bugs.webkit.org/attachment.cgi?id=34364&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks sane, non-harmful. :)  I've never worked with our geolocation code
before, so I am not able to help in that way.

I've not seen m_hFoo used to designate that foo is a handle.  Normally we would
write out Handle in the name if necessary.  Or we would have a HandlePtr that
new how to close in the destructor.  Sadly HandlePtr doesn't exist yet. :)


More information about the webkit-reviews mailing list