[webkit-reviews] review granted: [Bug 25989] [Gtk] Enable accessibility in Gtk DRT : [Attachment 34361] patch with ChangeLog

[bugzilla-daemon at webkit.org]

Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 25989: [Gtk] Enable accessibility in Gtk DRT
https://bugs.webkit.org/show_bug.cgi?id=25989

Attachment 34361: patch with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=34361&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +AtkObject* webkit_accessible_get_focused_element(WebKitAccessible*
accessible)
> +{
> +    if (!accessible->m_object)
> +	   return 0;
> +
> +    // FIXME: update the backing store once we have one.

I'm not sure what this is.

> +AtkObject* webkit_web_frame_get_focused_accessible_element(WebKitWebFrame*
frame)
> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), NULL);
> +
> +#if HAVE(ACCESSIBILITY)
> +    if (!AXObjectCache::accessibilityEnabled())
> +	   AXObjectCache::enableAccessibility();
> +
> +    WebKitWebFramePrivate* priv = frame->priv;
> +    if (!priv->coreFrame || !priv->coreFrame->document())
> +	   return NULL;
> +
> +    RenderView* root = static_cast<RenderView
*>(priv->coreFrame->document()->renderer());

I think you should use the new toRenderView methods introduced recently here.


> +double AccessibilityUIElement::intValue()
> +{
> +    GValue value = { 0, };

You should use the full initializer here ( GValue value = { 0, { { 0 } } }),
otherwise I think you'll get compiler warnings.

Looks good to me otherwise, please land with those things fixed.