[webkit-reviews] review requested: [Bug 28073] Cross-platform ICO decoder gets wrong bit depth for icons w/o color count : [Attachment 34342] patch w/test, no expected results

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 16:43:45 PDT 2009


Peter Kasting <pkasting at google.com> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 28073: Cross-platform ICO decoder gets wrong bit depth for icons w/o color
count
https://bugs.webkit.org/show_bug.cgi?id=28073

Attachment 34342: patch w/test, no expected results
https://bugs.webkit.org/attachment.cgi?id=34342&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Here's the patch with the style violation fixed and a layout test added.  I
don't seem to be able to generate expected pixel results on my Windows box. 
Expected results should be identical for all platforms, though.  Not sure if
there's some way to have the buildbot do this for me or something?


More information about the webkit-reviews mailing list