[webkit-reviews] review denied: [Bug 27437] make HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based standards under gobject bindings : [Attachment 33377] removes tabs, corrects date

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 15:53:15 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33377: removes tabs, corrects date
https://bugs.webkit.org/attachment.cgi?id=33377&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Luke, everything in this patch looks ok on the substance. The one problem I see
is that the ChangeLog hunk is wrong - it has lines above the + lines. This will
lead to the patch applying wrong. Please move the ChangeLog entry to the top of
WebCore/ChangeLog and resubmit, then I will r+ this. Everything else looks
fine. (r- for minor technicality).


More information about the webkit-reviews mailing list