[webkit-reviews] review requested: [Bug 28084] KURL ref() methods should be fragmentIdentifier() methods : [Attachment 34327] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 14:14:43 PDT 2009


Brady Eidson <beidson at apple.com> has asked  for review:
Bug 28084: KURL ref() methods should be fragmentIdentifier() methods
https://bugs.webkit.org/show_bug.cgi?id=28084

Attachment 34327: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=34327&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Pretty mechanical change.

But there are some very subtle "null versus empty" changes, also, so even if
this get's an r+, note that I'm still running all the layout tests on all the
platforms I have access to, just to make sure those subtle changes don't break
anything, and I'll finish that and land after the weekend.


More information about the webkit-reviews mailing list