[webkit-reviews] review denied: [Bug 27734] WINCE PORT: font related changes : [Attachment 34307] build fixes and minor bug fixes

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27734: WINCE PORT: font related changes
https://bugs.webkit.org/show_bug.cgi?id=27734

Attachment 34307: build fixes and minor bug fixes
https://bugs.webkit.org/attachment.cgi?id=34307&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Are you sure that min<int> will compile on other platforms?  I feel like we've
dealt with the min/max issue on windows before in other ways.  Please grep the
source to see how it's dealt with elsewhere.

This needs a why comment:
29 #if !PLATFORM(WINCE)
227230	   mutable SCRIPT_CACHE m_scriptCache;
228231	   mutable SCRIPT_FONTPROPERTIES* m_scriptFontProperties;
229232 #endif
your note about it saving space in the ChangeLog is a fine comment, just put it
in teh soruce code too.