[webkit-reviews] review requested: [Bug 28078] WebInspector: Move object properties read / write access into InjectedScript : [Attachment 34321] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 7 13:43:23 PDT 2009
Pavel Feldman <pfeldman at chromium.org> has asked for review:
Bug 28078: WebInspector: Move object properties read / write access into
InjectedScript
https://bugs.webkit.org/show_bug.cgi?id=28078
Attachment 34321: patch
https://bugs.webkit.org/attachment.cgi?id=34321&action=review
------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
(In reply to comment #2)
> (From update of attachment 34309 [details])
>
>
> I think this should go into a new file and not ObjectPropertiesSection.js,
> since it is used in other places and not specific to the
> ObjectPropertiesSection.
>
Done.
> I am not too fond of the Ref suffix. Do you like ObjectProxy better?
>
Done.
>
> You should add a comment about this, this looks temporary.
>
Done (added TODO).
>
> You hould add a comment about this being temporary.
Done (added TODO).
More information about the webkit-reviews
mailing list