[webkit-reviews] review denied: [Bug 27561] ImageDecoder enhancements for WINCE port : [Attachment 33341] make image decoders use ImageFrameSink

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 13:28:25 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33341: make image decoders use ImageFrameSink
https://bugs.webkit.org/attachment.cgi?id=33341&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Tabs:
84	for (int scaledX = 0;;) {
 85		int x = scaledX * zoom + 0.5;
 86		if (x < width) {
 87			m_scaledColumns.append(x);
 88			++scaledX;
 89		} else
 90			break;
 91	}
Why not while(true) there?

No:
 #if USE(IMAGEFRAMESINK)
 251 #else

Peter Kasting should see this patch.

r- for tabs.


More information about the webkit-reviews mailing list