[webkit-reviews] review denied: [Bug 27561] ImageDecoder enhancements for WINCE port : [Attachment 33342] decode from stream source data

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 13:26:35 PDT 2009


Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33342: decode from stream source data
https://bugs.webkit.org/attachment.cgi?id=33342&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
No ChangeLog, r-.

Normaly this would be in the header:
+    unsigned currentBufferSize() const { return m_currentBufferSize; }

no c-style casts:
+	 if (!querySize && m_reader.images_decoded >= (int)haltFrame)

while please:
+	 for (;!m_jobComplete;) {

Why?
+#if PLATFORM(WINCE) && PLATFORM(TORCHMOBILE)
+	 m_secondaryReader->decode(*m_data, GIFFrameCountQuery);
+#else
	 m_secondaryReader->decode(m_data.get(), GIFFrameCountQuery);
+#endif

Peter Kasting should see and comment on this patch please.


More information about the webkit-reviews mailing list