[webkit-reviews] review denied: [Bug 27885] Add QNX as supported platform : [Attachment 33880] Patch making WebKitCore and JavaScriptCore compile on QNX

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 11:22:31 PDT 2009


Eric Seidel <eric at webkit.org> has denied Harald Fernengel
<harry at kdevelop.org>'s request for review:
Bug 27885: Add QNX as supported platform
https://bugs.webkit.org/show_bug.cgi?id=27885

Attachment 33880: Patch making WebKitCore and JavaScriptCore compile on QNX
https://bugs.webkit.org/attachment.cgi?id=33880&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We have LOG macros for this:
+#ifndef NDEBUG
+	     perror("Unable to open /proc/self:");
+#endif

No c-style casts in c++:
+	 stackBase = (void*)threadInfo.stkbase;

r-.  Please explain why this shouldn't use (or expand and then use) the
Threading abstraction model in Threading*


More information about the webkit-reviews mailing list