[webkit-reviews] review denied: [Bug 26949] WebCore part of the Haiku WebKit port : [Attachment 33042] Patch to add Haiku-specific drawing files for WebCore/platform/graphics/.

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 33042: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=33042&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Better if m_data could be an OwnPtr for haiku:
 79	delete m_data;

Why?
setFocusRingColorChangeFunction

Spacing:
 230	     BRegion	region;

It's better to have conversion funtions outside of these setters:
302	cap_mode mode = B_BUTT_CAP;
 303	 switch (lineCap) {
 304	 case RoundCap:

I think CG follows that model.

So remove it:
61	   // FIXME: Not sure why be_app is checked
 62	    if (be_app)
 63		delete m_frame;

Please break this into smaller patches.  AGain, parts of hsi woudl be
super-easy to approve.	Other parts no.  If you posted a patch with just the
empty implementatins that would be an easy r+, the harder stuff can e done in
separate patches.