[webkit-reviews] review denied: [Bug 28073] Cross-platform ICO decoder gets wrong bit depth for icons w/o color count : [Attachment 34294] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 10:55:26 PDT 2009


Eric Seidel <eric at webkit.org> has denied Peter Kasting <pkasting at google.com>'s
request for review:
Bug 28073: Cross-platform ICO decoder gets wrong bit depth for icons w/o color
count
https://bugs.webkit.org/show_bug.cgi?id=28073

Attachment 34294: patch
https://bugs.webkit.org/attachment.cgi?id=34294&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You and your wrapping!

Test case?

Our style is a bit lame, but this is technically stylistically wrong:
+	 if (colorCount == 0)

r- for lack of test.


More information about the webkit-reviews mailing list