[webkit-reviews] review denied: [Bug 26988] Haiku-specific files for WebCore : [Attachment 32875] Patch to add a fifth bunch of Haiku-specific files for WebCore.

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32875: Patch to add a fifth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32875&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Here are some other things to fix up in the code.  I gave examples in places
but the whole patch should be examined for the issues.

Needs a check-webkit-style pass.


Also, look at spacing. There are several places. Here's an example:
      110	  BView*	view=i.context->platformContext();
      No spaces around =.  To much space after BView* (actually it may be a
TAB).

    112 	if (isEnabled( o )) {
    No spaces to the left of ( or to the right of ).


Odd indentation:
    170 	      
view->SetHighColor(tint_color(ui_color(B_KEYBOARD_NAVIGATION_COLOR),
    179 		    B_DISABLED_MARK_TINT));
  Typically indented to the nested ( on the previous line.

    182 		    // needed because of anti-aliasing
  The comment should be aligned with the code and be formed like a sentence
(starting with a capital and ending with a period).
    183 		view->StrokeLine(BPoint(rect.left, rect.top),


Variable names should be words.  Example: "const RenderObject::PaintInfo& i" 


" //code taken from the Haiku source code (CheckBox.cpp)"
What is the license on the Haiku source?  Does it need to be added to the file
and is it WebKit compatible?