[webkit-reviews] review requested: [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings : [Attachment 34284] split to multiple files, renamed #if 0 to #if __TODO_BUG_20586__

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 09:51:09 PDT 2009


Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked Eric Seidel
<eric at webkit.org> for review:
Bug 27426: adding GDOMBinding.cpp/h as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27426

Attachment 34284: split to multiple files, renamed #if 0 to #if
__TODO_BUG_20586__
https://bugs.webkit.org/attachment.cgi?id=34284&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
ok the other alternative would be #if ENABLE(TODO_GOBJECT_SVG) or maybe #if
ENABLE(GOBJECT_SVG) which would of course not exist, which would be the whole
point: disable the code until gobject bindings get 2D SVG Canvas [in a few
months time].

i'm _really_ reluctant to have that code cut out.  NULL is returned at the
moment, deliberately, to enforce non-availability of 2D Canvas objects.  anyone
hunting through the code _without_ the #ifdef'd TODO on it will definitely have
a "wtf" moment.


More information about the webkit-reviews mailing list