[webkit-reviews] review denied: [Bug 27909] WebKit cannot decode jpegs that are in CMYK or YCCK format : [Attachment 34250] Fix style problems, extract rgb_convert_rgba() function

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 08:54:44 PDT 2009


Eric Seidel <eric at webkit.org> has denied Nico Weber <thakis at chromium.org>'s
request for review:
Bug 27909: WebKit cannot decode jpegs that are in CMYK or YCCK format
https://bugs.webkit.org/show_bug.cgi?id=27909

Attachment 34250: Fix style problems, extract rgb_convert_rgba() function
https://bugs.webkit.org/attachment.cgi?id=34250&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
cmyk_convert_rgba and rgb_convert_rgba should follow WebKit style naming
(unless we have good reason not do here?)

Something like:
convertRGBToRGBA
convertCMYKToRGBA
would be webkit style naming.

Otherwise looks great.	If you were a committer I would r+ this and you could
fix it when landing.


More information about the webkit-reviews mailing list