[webkit-reviews] review granted: [Bug 28067] TransformationMatrix should have rectToRect convenience function : [Attachment 34271] Adds method rectToRect

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 7 08:05:50 PDT 2009

Darin Adler <darin at apple.com> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 28067: TransformationMatrix should have rectToRect convenience function

Attachment 34271: Adds method rectToRect

------- Additional Comments from Darin Adler <darin at apple.com>
Does this have the desirable behavior when from.width() or from.height() is 0?

This does not match the pattern of other functions that manipulate the matrix.
For example, we don't have a function to return the identity matrix. Instead we
have a setter, makeIdentity(). Probably this should be makeRectToRect() or
makeIdentity() should be changed.

We don't have any other static member functions to create new matrices. And in
classes where we do have such functions we normally use the word "create" in
the name of the function.

Seems OK to add it.

I'm going to say r=me, but I think the class's interface is a little weak and
getting a little weaker.

More information about the webkit-reviews mailing list