[webkit-reviews] review denied: [Bug 27425] adding auto-generator support for GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 34164] tidier workaround for skipping DataGrid

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27425: adding auto-generator support for
GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 34164: tidier workaround for skipping DataGrid
https://bugs.webkit.org/attachment.cgi?id=34164&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch fails to build:

perl -I WebCore/bindings/scripts WebCore/dom/make_names.pl --tags
WebCore/html/HTMLTagNames.in --attrs WebCore/html/HTMLAttributeNames.in
--factory --wrapperFactory --extraDefines " ENABLE_VIDEO=1 ENABLE_RUBY=1"
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 540.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 551.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 556.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 540.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 551.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 556.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 674.
"my" variable $name masks earlier declaration in same scope at
WebCore/dom/make_names.pl line 674.
Global symbol "%tag" requires explicit package name at
WebCore/dom/make_names.pl line 317.
syntax error at WebCore/dom/make_names.pl line 345, near ");"
syntax error at WebCore/dom/make_names.pl line 380, near ");"
syntax error at WebCore/dom/make_names.pl line 610, near ");"
syntax error at WebCore/dom/make_names.pl line 625, near ");"
syntax error at WebCore/dom/make_names.pl line 922, near ");"
Global symbol "$tagName" requires explicit package name at
WebCore/dom/make_names.pl line 1084.
syntax error at WebCore/dom/make_names.pl line 1084, near ");"
Execution of WebCore/dom/make_names.pl aborted due to compilation errors.
Global symbol "%tag" requires explicit package name at
WebCore/dom/make_names.pl line 317.
syntax error at WebCore/dom/make_names.pl line 345, near ");"
syntax error at WebCore/dom/make_names.pl line 380, near ");"
syntax error at WebCore/dom/make_names.pl line 610, near ");"
syntax error at WebCore/dom/make_names.pl line 625, near ");"
syntax error at WebCore/dom/make_names.pl line 922, near ");"
Global symbol "$tagName" requires explicit package name at
WebCore/dom/make_names.pl line 1084.
syntax error at WebCore/dom/make_names.pl line 1084, near ");"
Execution of WebCore/dom/make_names.pl aborted due to compilation errors.
make: *** [HTMLNames.cpp] Error 255
make: *** Waiting for unfinished jobs....
make: *** [HTMLElementFactory.cpp] Error 255