[webkit-reviews] review denied: [Bug 27651] [Qt] QWebPluginDatabase API : [Attachment 33894] Add normalizePath() function to the FileSystem files.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 20:37:37 PDT 2009


Eric Seidel <eric at webkit.org> has denied Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33894: Add normalizePath() function to the FileSystem files.
https://bugs.webkit.org/attachment.cgi?id=33894&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems OK.	Maybe it should be called normalizePathForComparison if it's
only for comparison.  It's unclear what "normalize" should actually do?  Does
it resolve symlinks?  Does it remove traililing '/' chars?  Does it return the
~1 windows form of paths?  r- for more explanation and or a better name...

In general I'm in favor of the concept though.	Another way would be to to just
have a arePathsEqual function. :)


More information about the webkit-reviews mailing list