[webkit-reviews] review granted: [Bug 27711] SVG Filter need feColorMatrix implementation : [Attachment 34041] SVG feColorMatrix-implementation

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 27711: SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Attachment 34041: SVG feColorMatrix-implementation
https://bugs.webkit.org/attachment.cgi?id=34041&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sigh.  We totally need Color accessors to:
127	    srcPixelArray->get(pixelByteOffset, r);
 128	     srcPixelArray->get(pixelByteOffset + 1, g);
 129	     srcPixelArray->get(pixelByteOffset + 2, b);
 130	     srcPixelArray->get(pixelByteOffset + 3, a);

Sigh.  I still think function pointers would be cleaner than templates.

I'll r+ this, but I definitely would prefer function pointers for this sort of
thing.	Modern compilers should be able to handle the jump prediction.