[webkit-reviews] review denied: [Bug 27426] adding GDOMBinding.cpp/h as part of GObject bindings : [Attachment 33972] corrections noted from other reviews (e.g. removal of args on prototypes)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 19:01:06 PDT 2009


Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27426: adding GDOMBinding.cpp/h as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27426

Attachment 33972: corrections noted from other reviews (e.g. removal of args on
prototypes)
https://bugs.webkit.org/attachment.cgi?id=33972&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Bunch of Style violations.

Please don't post patches with #if 0 code.

There are a billion includes in this file.  maybe we should split some of this
out into separate files?


More information about the webkit-reviews mailing list