[webkit-reviews] review denied: [Bug 27371] [WINCE] Add WinCE specific platform/text files to WebCore : [Attachment 33203] Latest version with latest cpplint cleanup

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 18:29:51 PDT 2009


Eric Seidel <eric at webkit.org> has denied Adam Treat <treat at kde.org>'s request
for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 33203: Latest version with latest cpplint cleanup
https://bugs.webkit.org/attachment.cgi?id=33203&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This is too large for me to review.

Why are we adding:
platform/text/wince/Euc_jp.cpp
?

Now that you all have your magical UnicodeCE library, is this something that
shoudl go in that?  Does the rest of WebCore want this Euc_jp.cpp file?  How is
it generated, where does it come from?


More information about the webkit-reviews mailing list