[webkit-reviews] review requested: [Bug 27889] [Chromium] RTL autocomplete popup is not layout correctly. : [Attachment 34240] patch w/ manual test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 18:11:49 PDT 2009

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 27889: [Chromium] RTL autocomplete popup is not layout correctly.

Attachment 34240: patch w/ manual test

------- Additional Comments from Xiaomei Ji <xji at chromium.org>
1. Since the change only affects Chromium's <select> and autofill, I do not
think it can be auto-tested.
Please let me know otherwise.

2. For autofill, I am using the input element's direction to display the item
in drop-down list, mainly to keep the display in drop-down list consistent with
the display in input field.
for <select>, I leave the directionality of item in drop-down list as
auto-detected (as first strong directional character's direction).

More information about the webkit-reviews mailing list