[webkit-reviews] review denied: [Bug 27920] Right click on timeline of media controls panel cause seek : [Attachment 33934] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 6 18:03:14 PDT 2009
Eric Seidel <eric at webkit.org> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27920: Right click on timeline of media controls panel cause seek
https://bugs.webkit.org/show_bug.cgi?id=27920
Attachment 33934: patch
https://bugs.webkit.org/attachment.cgi?id=33934&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.
Your if should use == LefButton (if that exists), or a comment to explain that
0 is the left button.
Style viloation:
1 if (window.eventSender)
12 {
If you were a committer I would just r+ and you could fix this when landing.
Since I don't think you are, please re-post with the two above fixes
More information about the webkit-reviews
mailing list