[webkit-reviews] review denied: [Bug 26182] Need to be able to resize the columns in LocalStorage view in Web Inspector : [Attachment 34231] Patch that adds an initial implementation of making the columns of a DataGrid in the Web Inspector resizable

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Jessie Berlin
<jberlin at apple.com>'s request for review:
Bug 26182: Need to be able to resize the columns in LocalStorage view in Web
Inspector
https://bugs.webkit.org/show_bug.cgi?id=26182

Attachment 34231: Patch that adds an initial implementation of making the
columns of a DataGrid in the Web Inspector resizable
https://bugs.webkit.org/attachment.cgi?id=34231&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
You will want to call updateWidths when the window resizes and when the sidebar
resizes. Both of those cases will adjust the datagrid widths.

Take a look at ResourcesPanel's _updateSidebarWidth. At the end of that method
it does:

	var visibleView = this.visibleView;
	if (visibleView && "resize" in visibleView)
	    visibleView.resize();

You should add this to ResourcesPanel and ProfilesPanel. Then you can implement
a resize method in ProfileView and DOMStorageItemsView to call updateWidths.

There is also a resize method on the Panel that is called when the window
resizes. You should do what ResourcesPanel does in the other two panels (sans
the _updateGraphDividersIfNeeded).

    resize: function()
    {
	this._updateGraphDividersIfNeeded();

	var visibleView = this.visibleView;
	if (visibleView && "resize" in visibleView)
	    visibleView.resize();
    },

Otherwise the patch is correct.