[webkit-reviews] review denied: [Bug 28017] box-shadow's spread is ignored with <table> : [Attachment 34133] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 14:46:20 PDT 2009

Eric Seidel <eric at webkit.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 28017: box-shadow's spread is ignored with <table>

Attachment 34133: Patch v1

------- Additional Comments from Eric Seidel <eric at webkit.org>
If you're going to edit the generated template like this, you need to also
modify make-js-test-wrappers so ignore your .js file so that it doens't try to
re-gen a new version every time someone else runs make-js-test-wrappers.  (Yes,
I know this is all very poorly documented.)

Seems silly to leave this in the output:
 You should see no red.
 16 div:
 18 flexbox:
 20 table:

If you wrap it all in a div, you can easily remove that div before ending your

Otherwise the change looks fine to me.

r- for those nits.

More information about the webkit-reviews mailing list