[webkit-reviews] review requested: [Bug 28050] Qt Port does not use style colour as configured for input text and menu lists : [Attachment 34219] Patch to update RenderThemeQt.cpp style() color setting and associated tests.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 6 12:56:35 PDT 2009


Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 28050: Qt Port does not use style colour as configured for input text and
menu lists
https://bugs.webkit.org/show_bug.cgi?id=28050

Attachment 34219: Patch to update RenderThemeQt.cpp style() color setting and
associated tests.
https://bugs.webkit.org/attachment.cgi?id=34219&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
This patch removes the override of the style colour and adds in two new tests
to verify this functionality

New tests include

fast/forms/menulist-style-color.html
fast/forms/text-style-color.html

This patch also removes 4 tests from platform/qt/Skipped that now successfully
pass using the primary result set.

NOTE:  Please review only, with the addition of new tests, result sets will be
required for other platforms to build and test correctly and will need to be
updated after the initial commit.


More information about the webkit-reviews mailing list