[webkit-reviews] review denied: [Bug 27997] [V8] Style cleaning for WorkerContextExecutionProxy. : [Attachment 34116] Add info to ChangeLog

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Jian Li
<jianli at chromium.org>'s request for review:
Bug 27997: [V8] Style cleaning for WorkerContextExecutionProxy.
https://bugs.webkit.org/show_bug.cgi?id=27997

Attachment 34116: Add info to ChangeLog
https://bugs.webkit.org/attachment.cgi?id=34116&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
This looks good overall. A couple of comments:

> diff --git a/WebCore/bindings/v8/ScheduledAction.cpp
b/WebCore/bindings/v8/ScheduledAction.cpp
> index 298f6b1..ce4ecf1 100644
> --- a/WebCore/bindings/v8/ScheduledAction.cpp
> +++ b/WebCore/bindings/v8/ScheduledAction.cpp
> @@ -134,7 +134,7 @@ void ScheduledAction::execute(WorkerContext*
workerContext)
>  
>      if (!m_function.IsEmpty() && m_function->IsFunction()) {
>	   v8::HandleScope handleScope;
> -	   v8::Local<v8::Context> v8Context =
scriptController->proxy()->GetContext();
> +	   v8::Local<v8::Context> v8Context =
scriptController->proxy()->context();

Be careful, abarth is working on change to remove V8Proxy::context(), talk
w/him.


> +v8::Local<v8::Function>
V8DOMWrapper::getConstructor(V8ClassIndex::V8WrapperType type,
v8::Handle<v8::Context> context)
> +{
> +    // Enter the scope for this context to get the correct constructor.
> +    v8::Context::Scope scope(context);
> +
> +    return getConstructor(type, V8Proxy::getHiddenObjectPrototype(context));

> +}

Can we have a better, more specific name for this method and perhaps make it
private? It shouldn't be used outside of this class.