[webkit-reviews] review denied: [Bug 27209] Add WebSocket.idl : [Attachment 34112] Add WebSocket.idl and js binding classes

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 34112: Add WebSocket.idl and js binding classes
https://bugs.webkit.org/attachment.cgi?id=34112&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The commit-queue says this patch does not build:

    /Developer/usr/bin/gcc-4.2 -x c++ -arch i386 -fmessage-length=0 -pipe
-Wno-trigraphs -fno-exceptions -fno-rtti -fpascal-strings -fasm-blocks -O0
-Werror -Wnon-virtual-dtor -Wnewline-eof -DDISABLE_THREAD_CHECK
-DENABLE_3D_RENDERING -DENABLE_CHANNEL_MESSAGING -DENABLE_DATABASE
-DENABLE_DATAGRID -DENABLE_DOM_STORAGE -DENABLE_ICONDATABASE
-DENABLE_JAVASCRIPT_DEBUGGER -DENABLE_OFFLINE_WEB_APPLICATIONS -DENABLE_RUBY
-DENABLE_SVG -DENABLE_SVG_ANIMATION -DENABLE_SVG_AS_IMAGE
-DENABLE_SVG_DOM_OBJC_BINDINGS -DENABLE_SVG_FONTS -DENABLE_SVG_FOREIGN_OBJECT
-DENABLE_SVG_USE -DENABLE_VIDEO -DENABLE_WEB_SOCKETS -DENABLE_WORKERS
-DENABLE_XPATH -DENABLE_XSLT
-DWEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST -fvisibility-inlines-hidden
-fno-threadsafe-statics -mmacosx-version-min=10.5 -gdwarf-2
-I/Users/abarth/git/webkit/WebKitBuild/WebCore.build/Debug/WebCore.build/WebCor
e.hmap -Wall -Wextra -Wcast-align -Wcast-qual -Wchar-subscripts -Wextra-tokens
-Wformat=2 -Winit-self -Wmissing-format-attribute -Wmissing-noreturn -Wpacked
-Wpointer-arith -Wredundant-decls -Wundef -Wwrite-strings -Wshorten-64-to-32
-F/Users/abarth/git/webkit/WebKitBuild/Debug
-F/System/Library/Frameworks/Carbon.framework/Frameworks
-F/System/Library/Frameworks/ApplicationServices.framework/Frameworks
-I/Users/abarth/git/webkit/WebKitBuild/Debug/include -IForwardingHeaders -Iicu
-I/usr/include/libxslt -I/usr/include/libxml2
-I/Users/abarth/git/webkit/WebKitBuild/Debug/WebCoreSQLite3
-I/Users/abarth/git/webkit/WebKitBuild/Debug/DerivedSources/WebCore
-I/Users/abarth/git/webkit/WebKitBuild/WebCore.build/Debug/WebCore.build/Derive
dSources/i386
-I/Users/abarth/git/webkit/WebKitBuild/WebCore.build/Debug/WebCore.build/Derive
dSources -include
/var/folders/qt/qthS2Td+ExiMdusUTSRQrE+++TI/-Caches-/com.apple.Xcode.501/Shared
PrecompiledHeaders/WebCorePrefix-diivbhagnqkgohdrnsdwdkawzyxk/WebCorePrefix.h
-c /Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp -o
/Users/abarth/git/webkit/WebKitBuild/WebCore.build/Debug/WebCore.build/Objects-
normal/i386/WebSocket.o
cc1plus: warnings being treated as errors
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:79: warning: unused
parameter ‘message’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:118: warning: unused
parameter ‘eventType’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:118: warning: unused
parameter ‘listener’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:118: warning: unused
parameter ‘useCapture’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:123: warning: unused
parameter ‘eventType’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:123: warning: unused
parameter ‘listener’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:123: warning: unused
parameter ‘useCapture’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:128: warning: unused
parameter ‘event’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:128: warning: unused
parameter ‘ec’
/Users/abarth/git/webkit/WebCore/websockets/WebSocket.cpp:162: warning: unused
parameter ‘msg’