[webkit-reviews] review requested: [Bug 27059] Exclude Symbian platform from define of MIDDLE_ENDIAN : [Attachment 34180] Update of patch file for bug #27059

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 15:00:07 PDT 2009


Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27059: Exclude Symbian platform from define of MIDDLE_ENDIAN
https://bugs.webkit.org/show_bug.cgi?id=27059

Attachment 34180: Update of patch file for bug #27059
https://bugs.webkit.org/attachment.cgi?id=34180&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
I updated the patch according to the review comment.

Instead of adding a !SYMBIAN condition to the already hard to decipher 
negative conditional clause within the ARM block,
I added the proper __ARM_EABI__ flag to the SYMBIAN case.

In addition, I cleaned up the condition of the else branch in the ARM block
(removed redundant condition check).


More information about the webkit-reviews mailing list