[webkit-reviews] review denied: [Bug 13516] Color is only reported in rgb() format; should toggle between rgb() and hex : [Attachment 34175] Click Through Color Representations

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 13516: Color is only reported in rgb() format; should toggle between rgb()
and hex
https://bugs.webkit.org/show_bug.cgi?id=13516

Attachment 34175: Click Through Color Representations
https://bugs.webkit.org/attachment.cgi?id=34175&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
 78	    if (typeof this._nickname !== undefined) // would be set on parse
if there was a nickname

undefined should be "undefined"

 903			 function helper(newMode, content) {

Could this be named better?

 942				 (color.nickname) ? helper("nickname",
color.toNickname()) : helper("rgba", color.toRgba());

This would read better as a if block I think.

Awesome work, as always! Just fix up those 3 minor thigs.