[webkit-reviews] review denied: [Bug 27099] Elements with display none still gets focus and take part in the tab order : [Attachment 34174] Checking renderer() first

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 34174: Checking renderer() first
https://bugs.webkit.org/attachment.cgi?id=34174&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
No, in those cases we should check renderer() after calling
updateLayoutIgnorePendingStylesheets().

I still don't understand why Element does this work and Node does not -- it
makes sense for other nodes too.

But also, I'm a little worried about such a low level function calling
updateLayout. We'll need to examine all calls to isFocusable and make sure they
can handle a layout happening in the middle of the function right where they
call updateLayout. A better design might be to do the layout at a higher level
and have an assertion in isFocusable instead. Another possibility would be to
move isFocusable to the render tree which would implicitly do the same thing in
a clearer way.