[webkit-reviews] review requested: [Bug 27851] mutil-char constant warning in BMPImageDecoder.cpp under gcc : [Attachment 34171] Fix two different warnings

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 14:04:41 PDT 2009


Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27851: mutil-char constant warning in BMPImageDecoder.cpp under gcc
https://bugs.webkit.org/show_bug.cgi?id=27851

Attachment 34171: Fix two different warnings
https://bugs.webkit.org/attachment.cgi?id=34171&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
The original patch was sound.  I think the test failures encountered must have
been due to flakiness or another change.  Verified that this still decodes BMPs
OK.

I also fixed another warning I just introduced (sorry!).


More information about the webkit-reviews mailing list