[webkit-reviews] review requested: [Bug 28025] Add .ico decoding LayoutTest : [Attachment 34167] .ico LayoutTest

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 13:20:51 PDT 2009

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 28025: Add .ico decoding LayoutTest

Attachment 34167: .ico LayoutTest

------- Additional Comments from Peter Kasting <pkasting at google.com>
Here's the test.  Note that the CG .ico decoder has a bug in how it decodes
1-bit images; I've filed this on Apple's bug tracker and commented on it in the
test, so if the bug gets fixed it will hopefully be obvious that the expected
PNG should change.

There are still other types of decoding that could be tested (PNG-in-.ico,
negative tests of broken icons, a BMP decoder test that checks RLE-encoded
data), but this is at least better than nothing.

More information about the webkit-reviews mailing list