[webkit-reviews] review granted: [Bug 28004] [chromium] setting listeners on MessagePorts doesn't work in the worker process : [Attachment 34098] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 12:54:59 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 28004: [chromium] setting listeners on MessagePorts doesn't work in the
worker process
https://bugs.webkit.org/show_bug.cgi?id=28004

Attachment 34098: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=34098&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +    return PassRefPtr<EventListener>();

return 0;

will work just fine, too.

Why are we duplicating these in *Custom files? The logic is the same. Can we
possibly use a template or generate these?
If you're not up to mucking with this, can you file a bug about this?


More information about the webkit-reviews mailing list