[webkit-reviews] review denied: [Bug 24887] Wrong filename when dragging an image to the Desktop. : [Attachment 34160] Updated patch, refactoring Clipboard class

[bugzilla-daemon at webkit.org]

Jens Alfke <snej at chromium.org> has denied  review:
Bug 24887: Wrong filename when dragging an image to the Desktop.
https://bugs.webkit.org/show_bug.cgi?id=24887

Attachment 34160: Updated patch, refactoring Clipboard class
https://bugs.webkit.org/attachment.cgi?id=34160&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
As I described above, this patch moves most of the code into the base Clipboard
class. The existing declareAndWriteDragImage method is retained for
compatibility (to avoid having to modify every subclass) but it now has a base
implementation that invokes a new overloaded variant that's passed the
important info like the image data, filename, and HTML markup. Subclasses can
now just override the new method; I've changed ClipboardChromium to do this.

No layout tests are added. See above comments on the difficulty of testing this
functionality.