[webkit-reviews] review granted: [Bug 26460] Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality : [Attachment 34158] Return multiple frames from ICO decoder, v2 (for real)

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460

Attachment 34158: Return multiple frames from ICO decoder, v2 (for real)
https://bugs.webkit.org/attachment.cgi?id=34158&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I doubt the explicit namespace is needed here:
     WTF::deleteAllValues(m_bmpReaders);
 57	WTF::deleteAllValues(m_pngDecoders);

0 in C++
2     m_bmpReaders.fill(NULL, idCount);
 263	 m_pngDecoders.fill(NULL, idCount);

Seems odd the sides of the cast are different:
 302	 int width = static_cast<uint8_t>(m_data->data()[m_decodedOffset]);

virtual, no?
 44	    ~ICOImageDecoder();

Looks sane enough.  Please note the comments above.