[webkit-reviews] review requested: [Bug 26460] Cross-platform ICO decoder should return all icons in file as separate frames, sorted by decreasing quality : [Attachment 34155] Return multiple frames from ICO decoder, v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 11:34:43 PDT 2009


Peter Kasting <pkasting at google.com> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460

Attachment 34155: Return multiple frames from ICO decoder, v2
https://bugs.webkit.org/attachment.cgi?id=34155&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Updated patch.	I changed IconDirectoryEntry to WebKit style and replaced the
width and height members with an IntSize, which simplified a few things.  Also
replaced my cumbersome VectorInitializer calls with calls to fill().  Other
fixes as noted in my previous comments.  If you demand I modify my line
wrapping I will :)


More information about the webkit-reviews mailing list