[webkit-reviews] review denied: [Bug 28021] WINCE PORT: enable CachedFont : [Attachment 34150] the patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 11:19:56 PDT 2009


George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 28021: WINCE PORT: enable CachedFont
https://bugs.webkit.org/show_bug.cgi?id=28021

Attachment 34150: the patch
https://bugs.webkit.org/attachment.cgi?id=34150&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +#if PLATFORM(WINCE)
> +	   m_fontData = createFontCustomPlatformData(this);
> +	   m_data = 0;
> +#else
>	   m_fontData = createFontCustomPlatformData(m_data.get());
> +#endif

  This change should not be necessary.	We need to improve it in the platform
dependent code.


More information about the webkit-reviews mailing list