[webkit-reviews] review requested: [Bug 27984] cpp_style.py lacks checks for pointer and reference declaration style. : [Attachment 34137] Updated patch for cpp_style validation of pointer / references.

[bugzilla-daemon at webkit.org]

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27984: cpp_style.py lacks checks for pointer and reference declaration
style.
https://bugs.webkit.org/show_bug.cgi?id=27984

Attachment 34137: Updated patch for cpp_style validation of pointer /
references.
https://bugs.webkit.org/attachment.cgi?id=34137&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Patch has been updated with the following chanages.

1) Add unit tests.
2) Update unit test for c style cast to be processed as c style code (ie. don't
complain about the int *b)
3) Divide logic for C/C++ validation to properly support each style.
4) Tighten up logic of regex to compare to beginnings of lines only (greatly
reduces false matches)
5) Add extra check for references to avoid return &variable; matching.