[webkit-reviews] review requested: [Bug 27490] Web Sockets Test Infrastructure Part 1/3: Server : [Attachment 34124] Web Socket Server, in desired coding style, with shorter file names.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 5 01:52:13 PDT 2009


Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 27490: Web Sockets Test Infrastructure Part 1/3: Server
https://bugs.webkit.org/show_bug.cgi?id=27490

Attachment 34124: Web Socket Server, in desired coding style, with shorter file
names.
https://bugs.webkit.org/attachment.cgi?id=34124&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Thank you for your reviews.

- I've changed the coding style to conform with PEP 8.

- I've changed the #! line and other parts of the code
  such that the scripts will run with Python 2.3 and later.
  (I've tested with Python 2.3, 2.4, and 2.5)

- I've removed 'websocket_' from the file names except for
  websocket_http_server.py, for which the prefix is meaningful, IMHO.

- I've changed the protocol_version to HTTP/1.1.

- I've defined two kinds of "default port". One is as defined by the spec.
  The other is for testing.

Yuzo


More information about the webkit-reviews mailing list