[webkit-reviews] review denied: [Bug 27703] [V8] Teach ScheduledAction::execute about isolated worlds : [Attachment 33993] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 19:45:44 PDT 2009


Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27703: [V8] Teach ScheduledAction::execute about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27703

Attachment 33993: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33993&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
These are two separate changes.  1. to change queue to evaluate.  2.  to fix
ScheduledAction.

I don't really know what this does, but I trust you do:
 51	m_context.makeWeak();

These changes look both fine, but should be split into two.


More information about the webkit-reviews mailing list