[webkit-reviews] review granted: [Bug 27993] AXSliders are missing required attributes and actions : [Attachment 34079] patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27993: AXSliders are missing required attributes and actions
https://bugs.webkit.org/show_bug.cgi?id=27993

Attachment 34079: patch
https://bugs.webkit.org/attachment.cgi?id=34079&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // There's no support in ARIA to specify horizontal or vertical, so
everything should be horizontal.
> +    if ((m_object->isSlider() || m_object->isProgressIndicator()) &&
[attributeName isEqualToString:NSAccessibilityOrientationAttribute])
> +	   return NSAccessibilityHorizontalOrientationValue;

I'm not sure that's right. For <input type=range> we do know for sure whether
it's horizontal or vertical, so I'm not sure why ARIA makes this less practical
for that. And in the ARIA case is there a chance we could use the shape of the
rendered object to guess about horizontal vs. vertical?

> +    JSStringRef action = NULL;

We use 0 for this in WebKit coding style, not NULL.

r=me