[webkit-reviews] review denied: [Bug 27942] Form Reset does not work per w3c standard when single selection SELECT element has more than one option marked as selected. : [Attachment 34007] Proposed patch improved and test added

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Carol Szabo <carol.szabo at nokia.com>'s
request for review:
Bug 27942: Form Reset does not work per w3c standard when single selection
SELECT element has more than one option marked as selected.
https://bugs.webkit.org/show_bug.cgi?id=27942

Attachment 34007: Proposed patch improved and test added
https://bugs.webkit.org/attachment.cgi?id=34007&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This patch looks wrong. As written all it does is rename the boolean to
"isOptionSelected" and add a new, never-used "selectedOption".

> +	       selectedOption=optionElement;

Missing spaces around the "=" here.

> +</form></body></html>
> \ No newline at end of file

Please add the newline.

> Property changes on:
LayoutTests/fast/forms/select-reset-multiple-selections-4-single-selection.html

> ___________________________________________________________________
> Added: svn:executable
>    + *

Please don't check in executable .html files. You can fix this by using chmod
-x before adding the file to Subversion, or svn pd svn:executable after adding
the file to Subversion.

review- because the code change as posted doesn't seem to do anything!