[webkit-reviews] review denied: [Bug 27305] [WINCE] add WinCE-specific unicode implementation : [Attachment 34014] generated files for unicode/wince subdir

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 09:47:10 PDT 2009


Eric Seidel <eric at webkit.org> has denied Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27305: [WINCE] add WinCE-specific unicode implementation
https://bugs.webkit.org/show_bug.cgi?id=27305

Attachment 34014: generated files for unicode/wince subdir
https://bugs.webkit.org/attachment.cgi?id=34014&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't think we should check in these generated files.  I think the wince port
should use a support library instead to follow the model of the other ports in
the tree.  Alternatively, we could find a way to generate these files at
compile time.


More information about the webkit-reviews mailing list