[webkit-reviews] review granted: [Bug 27963] Worker layout tests should be refactored to enable testing SharedWorkers also : [Attachment 34020] patch with updated layout tests

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27963: Worker layout tests should be refactored to enable testing
SharedWorkers also
https://bugs.webkit.org/show_bug.cgi?id=27963

Attachment 34020: patch with updated layout tests
https://bugs.webkit.org/attachment.cgi?id=34020&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/LayoutTests/fast/workers/resources/shared-worker-common.js
b/LayoutTests/fast/workers/resources/shared-worker-common.js
>  function handleMessage(event, port) {
>      if (event.data == "ping")
>	   port.postMessage("PASS: Received ping message");
>      else if (event.data == "done")
>	   port.postMessage("DONE");
> -    else if (/eval.+/.test(evt.data)) {
> +    else if (/eval.+/.test(event.data)) {
>	   try {
> -	       port.postMessage(evt.data.substr(5) + ": " +
eval(evt.data.substr(5)));
> +	       port.postMessage(event.data.substr(5) + ": " +
eval(event.data.substr(5)));
>	   } catch (ex) {
> -	       port.postMessage(evt.data.substr(5) + ": " + ex);
> +	       port.postMessage(event.data.substr(5) + ": " + ex);

It seems like it would have been better to fix this in
https://bugs.webkit.org/show_bug.cgi?id=27927 where you are adding the file...
but at this point not worth changing both patches (which is maybe what you
thought as well).


Note that this needs https://bugs.webkit.org/show_bug.cgi?id=27927 to land
first since it changes files from that patch.