[webkit-reviews] review requested: [Bug 3749] XHTML 1.1 Ruby Annotation : [Attachment 34043] patch: new ruby implementation (reordering of renderers)

[bugzilla-daemon at webkit.org]

Roland Steiner <rolandsteiner at google.com> has asked Dave Hyatt
<hyatt at apple.com> for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 34043: patch: new ruby implementation (reordering of renderers)
https://bugs.webkit.org/attachment.cgi?id=34043&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
New implementation of the HTML5 ruby support.

As discussed with Dave Hyatt, this now works by re-ordering the render children
of otherwise standard RenderBlock objects, rather than doing special layouting.


This new implementation made it important to work in the face of DOM
manipulation, which I hope I have addressed fully.

Known limitations/bugs: 

.) Selection follows visual layout order, but text copy-paste follows HTML
order
.) In some cases there is some incorrect selection painting when selecting
right-to-left over the start of a ruby or ruby run.
   (There seems to be no problems if the selection is performed in the "normal"
left-to-right direction.)