[webkit-reviews] review granted: [Bug 27918] commit-queue mode for bugzilla-tool : [Attachment 34036] Patch v1

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 4 00:30:45 PDT 2009

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27918: commit-queue mode for bugzilla-tool

Attachment 34036: Patch v1

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems you should combine this with teh one I just reviewed.  No sense in adding
the command only to remove it again.

 217		     attachment['commit-queue'] = True # FIXME: Validate that
the flag was set by a committer.

validation is possible as soon as bug 27972 is reviewed.

Otherwise this looks great!

More information about the webkit-reviews mailing list