[webkit-reviews] review granted: [Bug 27958] WAI-ARIA: Implement 'aria-required' attribute. : [Attachment 34015] patch

[bugzilla-daemon at webkit.org]

Jon Honeycutt <jhoneycutt at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27958: WAI-ARIA: Implement 'aria-required' attribute.
https://bugs.webkit.org/show_bug.cgi?id=27958

Attachment 34015: patch
https://bugs.webkit.org/attachment.cgi?id=34015&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(revision
46735)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.cpp	(working copy)
> @@ -327,6 +327,11 @@ static JSValueRef getIsEnabledCallback(J
>      return JSValueMakeBoolean(context,
toAXElement(thisObject)->isEnabled());
>  }
>  
> +static JSValueRef getIsRequiredCallback(JSContextRef context, JSObjectRef
thisObject, JSStringRef propertyName, JSValueRef* exception)
> +{
> +    return JSValueMakeBoolean(context,
toAXElement(thisObject)->isRequired());
> +}
> +

No need to name the unused params.

> Index: WebKitTools/DumpRenderTree/AccessibilityUIElement.h
> ===================================================================
> --- WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(revision
46735)
> +++ WebKitTools/DumpRenderTree/AccessibilityUIElement.h	(working copy)
> @@ -95,6 +95,7 @@ public:
>      JSStringRef selectedTextRange();
>      bool supportsPressAction();
>      bool isEnabled();
> +    bool isRequired();
>      double clickPointX();
>      double clickPointY();
>  

Looks like this can be const.

r=me