[webkit-reviews] review denied: [Bug 27918] commit-queue mode for bugzilla-tool : [Attachment 34032] Work in progress

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 3 19:40:29 PDT 2009

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27918: commit-queue mode for bugzilla-tool

Attachment 34032: Work in progress

------- Additional Comments from Eric Seidel <eric at webkit.org>
We could key this choice off of an option some day:
6	  for bug_id in bug_ids:
147		 print "%s" % tool.bugs.bug_url_for_bug_id(bug_id)
 147		 print "%s" % bug_id

Danger Danger will robinson!
 366	     options.force_clean = True

I don't think we should --force-clean automagically.

Seems we should check the value of ['commit-queue'] here:
 239		 if 'commit-queue' in attachment and not

attachment.get('commit-queue', False) might do the trick.  I think
['commit-queue'] might throw an exception.

Otherwise looks good.  We need to fix the "destroying your current work state"
problem by forcing --force-clean.  We need to require something to be passed
before we go destroying data.

You should be aware of the proposed refactoring in:

(I really should split out the refactoring bits into a separate patch and get
it landed.)

More information about the webkit-reviews mailing list