[webkit-reviews] review granted: [Bug 27323] Better support for non-Cygwin SVN on Windows : [Attachment 34017] Handle varying line endings in svn-apply and svn-unapply

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 34017: Handle varying line endings in svn-apply and svn-unapply
https://bugs.webkit.org/attachment.cgi?id=34017&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> -    if (/^Index: (.+)/) {
> +    if (/^Index: (.*\S+)\s*$/) {

This change is not needed.  $_ has already been stripped of newlines and
carriage returns previously:

while (<>) {
    s/([\n\r]+)$//mg;

> -    if (/^Index: (.*)/) {
> +    if (/^Index: (.*\S+)\s*$/) {

This is also not needed for the same reason.

r=me without the above two changes.